[TAS-3080] 🚸 Enhance search behavior #2018
Merged
+80
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AuroraHuang22
added a commit
that referenced
this pull request
Jan 16, 2025
williamchong
requested changes
Jan 16, 2025
| 'rounded-[0px] desktop:rounded-[10px]', | ||
| 'transition-[width]', | ||
| 'duration-[5000]', | ||
| 'duration-[300]', | ||
| 'ease-in-out', | ||
| ]" | ||
| > | ||
| <IconSearch /> |
There was a problem hiding this comment.
Can we make this icon clickable so that it also serve as the open/submit button if people can't press enter?
There was a problem hiding this comment.
we have submit button when open
src/components/SearchBar.vue
Outdated
| this.randomKeywords?.[0] || this.$t('gutenberg_search_placeholder'); | ||
| this.$emit('input', fallbackKeyword); | ||
| handleInput(event) { | ||
| this.currentSearchQuery = event.target.value; |
There was a problem hiding this comment.
I think we don't need to set currentSearchQuery explicitly in @input if it is in v-model
There was a problem hiding this comment.
nwingt
added a commit
that referenced
this pull request
Jan 22, 2025
williamchong
approved these changes
Jan 22, 2025
nwingt
added a commit
that referenced
this pull request
Jan 23, 2025
nwingt
requested changes
Jan 23, 2025
src/components/SearchBar.vue
Outdated
| 'h-full', | ||
| isSearchOpen && 'pl-[16px] pr-[4px]', |
There was a problem hiding this comment.
Suggested change
| isSearchOpen && 'pl-[16px] pr-[4px]', | |
| { 'pl-[16px] pr-[4px]': isSearchOpen }, |
There was a problem hiding this comment.
nwingt
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2025-01-16.7.53.08.mp4